chore: Add dedicated CI workflow for 3rd-party integrations by itaybre · Pull Request #6945 · getsentry/sentry-cocoa

itaybre · 2025-12-01T20:12:58Z

#skip-changelog

Add dedicated CI workflow for 3rd-party integrations

Moves 3rd-party integration tests (SentrySwiftLog, SentrySwiftyBeaver, SentryCocoaLumberjack, SentryPulse) from test.yml into a dedicated test-3rd-party-integrations.yml workflow with its own file-filter trigger.

Pre-builds XCFrameworks from source once and shares them across all integration test jobs (instead of using swift package edit or the latest release)
Each integration is tested via swift test on macOS.

Closes #6973

github-actions · 2025-12-01T21:07:11Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1219.28 ms	1253.78 ms	34.50 ms
Size	24.14 KiB	1.11 MiB	1.09 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`a1a9260`	1192.15 ms	1229.80 ms	37.64 ms
`0d145c3`	1224.04 ms	1255.34 ms	31.30 ms
`edcda5a`	1217.52 ms	1248.72 ms	31.20 ms
`09a80f2`	1214.78 ms	1237.85 ms	23.07 ms
`4b41eee`	1209.96 ms	1243.12 ms	33.16 ms
`29b6704`	1216.31 ms	1251.91 ms	35.60 ms
`79cee27`	1214.65 ms	1238.66 ms	24.01 ms
`83bf9af`	1213.30 ms	1234.18 ms	20.89 ms
`2400b80`	1230.26 ms	1261.19 ms	30.93 ms
`b5c1b24`	1217.94 ms	1248.76 ms	30.82 ms

App size

Revision	Plain	With Sentry	Diff
`a1a9260`	24.14 KiB	1.08 MiB	1.06 MiB
`0d145c3`	24.14 KiB	1.07 MiB	1.05 MiB
`edcda5a`	24.14 KiB	1.08 MiB	1.06 MiB
`09a80f2`	24.14 KiB	1.10 MiB	1.08 MiB
`4b41eee`	24.14 KiB	1.09 MiB	1.07 MiB
`29b6704`	24.14 KiB	1.06 MiB	1.04 MiB
`79cee27`	24.14 KiB	1.10 MiB	1.08 MiB
`83bf9af`	24.14 KiB	1.04 MiB	1.02 MiB
`2400b80`	24.14 KiB	1.10 MiB	1.07 MiB
`b5c1b24`	24.14 KiB	1.06 MiB	1.04 MiB

Previous results on branch: itay/add_ci_tests

Startup times

Revision	Plain	With Sentry	Diff
`9b06a22`	1217.45 ms	1251.72 ms	34.27 ms
`47d1029`	1207.77 ms	1238.34 ms	30.57 ms
`1ca6a17`	1215.29 ms	1240.23 ms	24.94 ms
`474ced6`	1218.85 ms	1260.94 ms	42.09 ms
`c99cc12`	1225.96 ms	1259.34 ms	33.38 ms
`458120a`	1227.60 ms	1264.52 ms	36.92 ms
`c9d2398`	1229.38 ms	1251.02 ms	21.65 ms
`cfb43c4`	1209.69 ms	1247.80 ms	38.11 ms
`6c794f4`	1219.40 ms	1251.57 ms	32.17 ms
`5d3049e`	1219.84 ms	1250.98 ms	31.14 ms

App size

Revision	Plain	With Sentry	Diff
`9b06a22`	24.14 KiB	1.10 MiB	1.08 MiB
`47d1029`	24.14 KiB	1.11 MiB	1.09 MiB
`1ca6a17`	24.14 KiB	1.08 MiB	1.06 MiB
`474ced6`	24.14 KiB	1.11 MiB	1.09 MiB
`c99cc12`	24.14 KiB	1.02 MiB	1016.90 KiB
`458120a`	24.14 KiB	1.02 MiB	1016.89 KiB
`c9d2398`	24.14 KiB	1.07 MiB	1.04 MiB
`cfb43c4`	24.14 KiB	1.02 MiB	1016.90 KiB
`6c794f4`	24.14 KiB	1.08 MiB	1.06 MiB
`5d3049e`	24.14 KiB	1.08 MiB	1.06 MiB

scripts/integration-xcodebuild.sh

.github/workflows/test-3rd-party-integrations.yml

philipphofmann

Thanks, I added a few comments.

.github/workflows/integrations-common.yml

scripts/integration-xcodebuild.sh

.github/workflows/integrations-common.yml

scripts/use-local-sentry-dependency.sh

codecov · 2025-12-04T19:36:25Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.321%. Comparing base (d492bc8) to head (6a0bffe).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #6945       +/-   ##
=============================================
- Coverage   85.335%   85.321%   -0.015%     
=============================================
  Files          480       480               
  Lines        28621     28620        -1     
  Branches     12400     12387       -13     
=============================================
- Hits         24424     24419        -5     
- Misses        4150      4153        +3     
- Partials        47        48        +1

see 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d492bc8...6a0bffe. Read the comment docs.

scripts/prepare-package.sh

swift package edit would pull in all dependencies, which would fail on release

.github/file-filters.yml

.github/workflows/unit-test-common.yml

denrase · 2026-02-09T11:00:50Z

@itaybre Added your feedback.

We do both swift test on macOS and xcodebuild style testing to test on iOS 18.5 simulator. Both test against sentry-cocoa build form source. We could still think about removing the latter, i'm not sure on this. It would be much simpler then.

@philipphofmann @philprime Would be great if one of you could also take a look, as we need a approving review. 🙇

… script

denrase · 2026-02-09T12:46:53Z

Updated to only do swift tests on macOS, as there is no iOS specific code to test. /cc @itaybre

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

.github/file-filters.yml

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

.github/file-filters.yml

denrase · 2026-02-11T08:31:40Z

@itaybre I'll approve this if it's ok with you.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

.github/file-filters.yml

itaybre · 2026-02-11T18:11:11Z

@itaybre I'll approve this if it's ok with you.

yes please, approve so we can merge it

I kinda forgot I couldn't approve

philprime

LGTM

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

.github/file-filters.yml

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

.github/workflows/test-3rd-party-integrations.yml

github-actions · 2026-02-12T22:15:14Z

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

.github/file-filters.yml

denrase and others added 5 commits December 1, 2025 16:48

Add SenrtySwiftLog integration

8f396d4

Add default swift package init .gitignore

2e79d06

chore: Add test workflow for swift log

f4c75d2

Add macOS version

5c5779f

Remove file-filter

01001dc

itaybre added the ready-to-merge Use this label to trigger all PR workflows label Dec 1, 2025

Update integration's package to use local path

2e9908c

denrase added 3 commits December 3, 2025 10:32

Merge branch 'main' into feat/add-swift-log-integration

c3a610e

Add ci job to run test

9fdbc39

Add files-changed gate

b096852

itaybre marked this pull request as ready for review December 3, 2025 13:44

itaybre requested review from noahsmartin, philipphofmann and philprime as code owners December 3, 2025 13:44

github-actions bot mentioned this pull request Dec 3, 2025

chore: Add test workflow for swift log #6973

Closed

cursor bot reviewed Dec 3, 2025

View reviewed changes

scripts/integration-xcodebuild.sh Outdated Show resolved Hide resolved

.github/workflows/test-3rd-party-integrations.yml Show resolved Hide resolved

itaybre and others added 5 commits December 3, 2025 17:10

Fix example commands

b00d89e

Add SPM test to required checks

c0d95c7

Merge branch 'main' into feat/add-swift-log-integration

d1851a8

update folder structure

5a72187

update name

2077ce0

philipphofmann reviewed Dec 4, 2025

View reviewed changes

itaybre added 4 commits December 4, 2025 15:40

Update sentry-xcodebuild.sh to be compatible with SPM packages

6516a2e

Add --update-path-to-sentry-cocoa to prepare-package.sh

7ab3886

Improve script

77e3f6e

Reuse existing unit-test-common.yml

6636b7b

sentry bot reviewed Dec 4, 2025

View reviewed changes

scripts/prepare-package.sh Outdated Show resolved Hide resolved

Fix path

a12905b

denrase added 3 commits February 9, 2026 11:03

add simulatorAndmacOSOnly to build-xcframework-local.sh

7f8d16a

use sed intead of swift package edit

06387f2

swift package edit would pull in all dependencies, which would fail on release

include all related scripts to file filter

e785700

cursor bot reviewed Feb 9, 2026

View reviewed changes

.github/file-filters.yml Show resolved Hide resolved

denrase added 3 commits February 9, 2026 11:23

minor improvements

1d8c11f

remove unneeded scripts dir argument

72cd026

don’t install slather for som build

f096304

sentry bot reviewed Feb 9, 2026

View reviewed changes

.github/workflows/unit-test-common.yml Show resolved Hide resolved

denrase added 2 commits February 9, 2026 13:42

only run spm tests, revert changes to shared tests workflow and build…

b6f9f4b

… script

use macOSOnly

63cb6ee

cursor bot reviewed Feb 9, 2026

View reviewed changes

.github/file-filters.yml Show resolved Hide resolved

Merge branch 'main' into itay/add_ci_tests

9df643b

cursor bot reviewed Feb 10, 2026

View reviewed changes

.github/file-filters.yml Show resolved Hide resolved

Merge branch 'main' into itay/add_ci_tests

152c638

cursor bot reviewed Feb 11, 2026

View reviewed changes

.github/file-filters.yml Show resolved Hide resolved

itaybre added the Waiting for: Review ⏳ label Feb 12, 2026

philprime approved these changes Feb 12, 2026

View reviewed changes

Remove 3rd-party-integrations filter from unit test in file-filters.yml

7627228

itaybre enabled auto-merge (squash) February 12, 2026 18:36

cursor bot reviewed Feb 12, 2026

View reviewed changes

.github/file-filters.yml Show resolved Hide resolved

Add ci-utils.sh to file-filters.yml

8078e5a

cursor bot reviewed Feb 12, 2026

View reviewed changes

.github/workflows/test-3rd-party-integrations.yml Show resolved Hide resolved

Merge branch 'main' into itay/add_ci_tests

6a0bffe

itaybre merged commit c9976e2 into main Feb 12, 2026
204 checks passed

itaybre deleted the itay/add_ci_tests branch February 12, 2026 23:48

Uh oh!

Conversation

itaybre commented Dec 1, 2025 • edited by denrase Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add dedicated CI workflow for 3rd-party integrations

Uh oh!

github-actions bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: itay/add_ci_tests

Startup times

App size

Uh oh!

Uh oh!

Uh oh!

philipphofmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

denrase commented Feb 9, 2026

Uh oh!

denrase commented Feb 9, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

denrase commented Feb 11, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

itaybre commented Feb 11, 2026

Uh oh!

philprime left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 12, 2026

🚨 Detected changes in high risk code 🚨

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

itaybre commented Dec 1, 2025 •

edited by denrase

Loading

github-actions bot commented Dec 1, 2025 •

edited

Loading

codecov bot commented Dec 4, 2025 •

edited

Loading